Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade juniversalchardet to version 2.3.0 #124

Merged
merged 1 commit into from
Dec 1, 2018
Merged

upgrade juniversalchardet to version 2.3.0 #124

merged 1 commit into from
Dec 1, 2018

Conversation

albfernandez
Copy link
Contributor

Also use new function to detect charset only from BOM

@albfernandez
upgrade juniversalchardet to version 2.3.0
5776fa3 
Also use new function to detect charset only from BOM
@andreasrosdal andreasrosdal merged commit ce6099c into LibrePDF:master Dec 1, 2018
@andreasrosdal
Copy link
Contributor

Thanks!

@andreasrosdal
Copy link
Contributor

By the way, is there a way to make juniversalchardet an optional dependency?

@albfernandez albfernandez deleted the upgrade_juniversalchardet_2_3_0 branch December 1, 2018 16:23
@albfernandez
Copy link
Contributor Author

I'm not sure, but if you only use to detect BOM you can copy the method:
https://github.com/albfernandez/juniversalchardet/blob/0aace935a4ad4a848957bca62dd23c121221c934/src/main/java/org/mozilla/universalchardet/UniversalDetector.java#L227

juniversalchardet is MPL as OpenPDF is

@mwgmnn mwgmnn mentioned this pull request Aug 21, 2020
Closed
@lapo-luchini lapo-luchini mentioned this pull request Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albfernandez @andreasrosdal