Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getBytes with getISOBytes #614

Conversation

tulikavijay
Copy link

@tulikavijay tulikavijay commented Oct 19, 2021

Description of the new Feature/Bugfix

Describe here how you fixed the bug, or implemented the new feature.

Related Issue: #581

Unit-Tests for the new Feature/Bugfix

  • Unit-Tests added to reproduce the bug
  • Unit-Tests added to the added feature

Compatibilities Issues

Is anything broken because of the new code? Any changes in method signatures?

Testing details

Any other details about how to test the new feature or bugfix?

  • Removed one statement from the unit test as it was failing because of it : LayoutProcessor.enable(java.awt.Font.LAYOUT_RIGHT_TO_LEFT);
  • Locally this test - testAwtImage() is failing because of nullpointerException at this line: final URL systemResource = ClassLoader.getSystemResource("H.gif");

Let me know how to fix these

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tulikavijay
Copy link
Author

@asturio let me know if changes are required

@asturio
Copy link
Member

asturio commented Oct 30, 2021

@asturio let me know if changes are required

Hi, I want to check that with the Unit-Test. I think it is a little bit strange, that it failed.

@foto-andreas
Copy link

@asturio let me know if changes are required

Hi, I want to check that with the Unit-Test. I think it is a little bit strange, that it failed.

@asturio I think it fails if the system encoding is not compatible like on z/OS (using EBCDIC). So a unit test is always correct for ascii chars on unix or windows.

Andreas

@nadir35
Copy link

nadir35 commented Feb 18, 2022

@asturio let me know if changes are required

Hi, I want to check that with the Unit-Test. I think it is a little bit strange, that it failed.

@asturio I think it fails if the system encoding is not compatible like on z/OS (using EBCDIC). So a unit test is always correct for ascii chars on unix or windows.

Andreas

I can confirm that this is indeed the problem scenario. As I described in #581

@asturio Will this be merged anytime soon?

@asturio asturio linked an issue Mar 7, 2022 that may be closed by this pull request
@asturio
Copy link
Member

asturio commented Mar 13, 2022

fixed in #642

@asturio asturio closed this Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDFWriter uses wrong file.encoding to write XREF
4 participants