-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoding for cross reference table wrong #642
Conversation
…ng, instead of default system encoding, which is wrong for example on ibm zos, where default encoding is IBM-273.
Kudos, SonarCloud Quality Gate passed! |
Hi @soenkekueper , the test is not green. Can you take a look at it? |
Hey, The cause is that i've to reset the privafte field Charset.defaultCharset, for java property file.encoding to be evaluated. The change of file.encoding must be done, because if this is not changed, the test would also pass with the old implementation (on all systems that usw an ISO based enoding, which is the case). So i see the following options for now:
What would you suggest as best solution? |
I'll checkout your branch and try to make the test pass. |
When creating an pdf on an system with different default encoding (for example ibm z/os where IBM-273 is the default encoding) the cross reference table is written in that encoding and afterwards unreadable.
Description of the new Feature/Bugfix
When writing the cross reference table entries now the Method
PdfEncodings.convertToBytes
without encoding is used, so the values are written as ISO-8859-1 bytes instead of IBM-273 encoded values.Related Issue: #
Unit-Tests for the new Feature/Bugfix
jUnit Test
SimplePdfTest.testCrossReferenceTableEncoding()
addedCompatibilities Issues
No.
Testing details
I'll build this locally and include in our deployment and run on our z/os mainframe.