Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated pytorch_lightning.core.decorators.parameter_validation #13514

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Remove deprecated pytorch_lightning.core.decorators.parameter_validation #13514

merged 5 commits into from
Jul 11, 2022

Conversation

shantam-8
Copy link
Contributor

@shantam-8 shantam-8 commented Jul 3, 2022 •
edited by Borda
Loading

What does this PR do?

Fixes part of #12521

resolves #9525

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added breaking change Includes a breaking change community This PR is from the community labels Jul 3, 2022
@akihironitta akihironitta added this to the pl:1.7 milestone Jul 3, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 3, 2022
@akihironitta akihironitta changed the title Remove pytorch_lightning.core.decorators.parameter_validation from decorators Remove deprecated pytorch_lightning.core.decorators.parameter_validation Jul 3, 2022
@akihironitta akihironitta enabled auto-merge (squash) July 3, 2022 21:29
@akihironitta akihironitta mentioned this pull request Jul 6, 2022
Closed
44 tasks
@akihironitta akihironitta merged commit bdb6e40 into Lightning-AI:master Jul 11, 2022
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@shantam-8 @jerome-habana
Remove deprecated `pytorch_lightning.core.decorators.parameter_valida…
424fb0e 
…tion` (Lightning-AI#13514)

* Removal of depreciated code from decorators

* Update CHANGELOG.md

* Removed imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
breaking change Includes a breaking change community This PR is from the community ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@shantam-8 @awaelchli @carmocca @akihironitta