-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable auto parameters tying for TPUs #9525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
reviewed
Sep 28, 2021
SeanNaren
reviewed
Sep 28, 2021
SeanNaren
approved these changes
Sep 28, 2021
tchaton
reviewed
Sep 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #9525 +/- ##
=======================================
- Coverage 93% 93% -0%
=======================================
Files 177 178 +1
Lines 15460 15582 +122
=======================================
+ Hits 14317 14428 +111
- Misses 1143 1154 +11 |
rohitgr7
reviewed
Sep 28, 2021
rohitgr7
reviewed
Sep 28, 2021
awaelchli
reviewed
Sep 29, 2021
awaelchli
reviewed
Sep 29, 2021
ananthsub
reviewed
Sep 29, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
8135613
to
82bf7d3
Compare
awaelchli
approved these changes
Sep 30, 2021
ananthsub
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice work @kaushikb11 ! this simplifies TPU usage with Lightning and cleans up our API further!
ananthsub
approved these changes
Sep 30, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
kaushikb11
commented
Oct 1, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
for more information, see https://pre-commit.ci
…/PyTorchLightning/pytorch-lightning into feat/enable_auto_tying__for_tpus
11 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: tpu
Tensor Processing Unit
deprecation
Includes a deprecation
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8555
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃