Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto parameters tying for TPUs #9525

Merged
merged 33 commits into from
Oct 6, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Sep 14, 2021

What does this PR do?

Fixes #8555

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 self-assigned this Sep 27, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review September 28, 2021 09:21
@kaushikb11 kaushikb11 added feature Is an improvement or enhancement accelerator: tpu Tensor Processing Unit labels Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #9525 (6ad1dd9) into master (b054d21) will decrease coverage by 0%.
The diff coverage is 84%.

@@           Coverage Diff           @@
##           master   #9525    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         177     178     +1     
  Lines       15460   15582   +122     
=======================================
+ Hits        14317   14428   +111     
- Misses       1143    1154    +11     

@kaushikb11 kaushikb11 force-pushed the feat/enable_auto_tying__for_tpus branch from 8135613 to 82bf7d3 Compare September 30, 2021 09:16
@mergify mergify bot removed the has conflicts label Sep 30, 2021
@kaushikb11 kaushikb11 added the deprecation Includes a deprecation label Sep 30, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 30, 2021
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice work @kaushikb11 ! this simplifies TPU usage with Lightning and cleans up our API further!

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@kaushikb11 kaushikb11 merged commit f94faa9 into master Oct 6, 2021
@kaushikb11 kaushikb11 deleted the feat/enable_auto_tying__for_tpus branch October 6, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit deprecation Includes a deprecation feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable auto parameters tying for TPU
6 participants