Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated LightningModule.on_post_move_to_device #13548

Merged
merged 10 commits into from
Jul 13, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jul 6, 2022

What does this PR do?

Part of #12521.

resolves #9525

Does your PR introduce any breaking changes? If yes, please list them.

Removes LightningModule.on_post_move_to_device.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @kaushikb11 @rohitgr7 @Borda @carmocca @justusschock @awaelchli @ananthsub @ninginthecloud @jjenniferdai

@akihironitta akihironitta added accelerator: tpu Tensor Processing Unit breaking change Includes a breaking change labels Jul 6, 2022
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready PRs ready to be merged label Jul 6, 2022
@carmocca carmocca enabled auto-merge (squash) July 12, 2022 11:55
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Jul 12, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 12, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 13, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 13, 2022
@carmocca carmocca merged commit feb8e7d into master Jul 13, 2022
@carmocca carmocca deleted the refactor/rm-on-post-move-to-device branch July 13, 2022 18:06
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
…-AI#13548)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@andreimargeloiu
Copy link

Is there a replacement for LightningModule.on_post_move_to_device ?

@carmocca
Copy link
Contributor

@andreimargeloiu this hook was misleading as it was only called when using the tpu spawn strategy. It's likely different from what you are looking for. But to answer you, the next hook to run would be on_fit_start

If you want a hook related to moving a batch to device, you can use one of on_before_batch_transfer, transfer_batch_to_device, on_after_batch_transfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit breaking change Includes a breaking change hooks Related to the hooks API lightningmodule pl.LightningModule ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants