-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated LightningModule.on_post_move_to_device
#13548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…-AI#13548) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Is there a replacement for |
@andreimargeloiu this hook was misleading as it was only called when using the tpu spawn strategy. It's likely different from what you are looking for. But to answer you, the next hook to run would be If you want a hook related to moving a batch to device, you can use one of |
What does this PR do?
Part of #12521.
resolves #9525
Does your PR introduce any breaking changes? If yes, please list them.
Removes
LightningModule.on_post_move_to_device
.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @kaushikb11 @rohitgr7 @Borda @carmocca @justusschock @awaelchli @ananthsub @ninginthecloud @jjenniferdai