-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename LightningLoggerBase
to Logger
#11971
Labels
good first issue
Good for newcomers
help wanted
Open to be worked on
logger
Related to the Loggers
refactor
Comments
daniellepintz
added
help wanted
Open to be worked on
refactor
logger
Related to the Loggers
labels
Feb 18, 2022
Hi, if no one has been assigned yet, can I work on this issue? |
Yup, just assigned you!! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
help wanted
Open to be worked on
logger
Related to the Loggers
refactor
Proposed refactor
loggers/logger.py
Logger
class by copying the code inLightningLoggerBase
LightningLoggerBase
subclassLogger
, and create a dummy constructor to emit a deprecation warning like in this example:https://github.com/PyTorchLightning/pytorch-lightning/blob/d61371922bf89a2b810711e67eee47f224be60cc/pytorch_lightning/plugins/training_type/ddp.py#L18-L24
Motivation
We want all of our main class names to follow the same standard.
Logger
should matchCallback
,Strategy
,Accelerator
, etc. Also, we want our files names to conform to standard ofaccelerators/accelerator.py
,strategies/strategy.py
, etc.Part of #11908
cc @justusschock @awaelchli @rohitgr7 @edward-io @Borda @ananthsub @kamil-kaczmarek @Raalsky @Blaizzy
The text was updated successfully, but these errors were encountered: