Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LightningLoggerBase to Logger #11971

Closed
daniellepintz opened this issue Feb 18, 2022 · 2 comments · Fixed by #12014
Closed

Rename LightningLoggerBase to Logger #11971

daniellepintz opened this issue Feb 18, 2022 · 2 comments · Fixed by #12014
Assignees
Labels
good first issue Good for newcomers help wanted Open to be worked on logger Related to the Loggers refactor

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Feb 18, 2022

Proposed refactor

Motivation

We want all of our main class names to follow the same standard. Logger should match Callback, Strategy, Accelerator, etc. Also, we want our files names to conform to standard of accelerators/accelerator.py, strategies/strategy.py, etc.

Part of #11908

cc @justusschock @awaelchli @rohitgr7 @edward-io @Borda @ananthsub @kamil-kaczmarek @Raalsky @Blaizzy

@daniellepintz daniellepintz added help wanted Open to be worked on refactor logger Related to the Loggers labels Feb 18, 2022
@ananthsub ananthsub added the good first issue Good for newcomers label Feb 18, 2022
@MohammedAlkhrashi
Copy link
Contributor

Hi, if no one has been assigned yet, can I work on this issue?

@daniellepintz
Copy link
Contributor Author

Yup, just assigned you!! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Open to be worked on logger Related to the Loggers refactor
Projects
None yet
3 participants