Rename ProgressBarBase to ProgressBar

[daniellepintz]

Proposed refactor

Class Names (conform to standard of Callback, Strategy, Accelerator)

• Rename LightningLoggerBase to Logger
• Rename AbstractProfiler and BaseProfiler to Profiler
• Rename ProgressBarBase to ProgressBar

Directory Names (conform to standard of callbacks/, strategies/, accelerators/)

• Rename profiler/ directory to profilers/

File Names (conform to standard of accelerators/accelerator.py, strategies/strategy.py)

• Rename loggers/base.py to loggers/logger.py
• Rename profiler/base.py to profiler/profiler.py
• Rename callbacks/base.py to callbacks/callback.py
• Rename loops/base.py to loops/loop.py

Motivation

Consistency in naming is important to give users and developers the cleanest and simplest experience when interacting with the code. It also makes it easier to find things in the codebase when everything conforms to the same standard.

cc @Borda @tchaton @rohitgr7 @akihironitta @justusschock @awaelchli

[awaelchli]

I am in favor of this. I propose to go with a longer deprecation than usual as this potentially impacts many import statements in user code. Lightning 2.0?

[adi-kmt]

Hi would like to work on this issue. I mean the parts that have not been done yet

[haesungpyun]

Hello, I'm a newbie to open source contribution. And I'm interested in this issue. If no one has been assigned, can I work on this issue?

[akihironitta]

Hi @haesungpyun! Thank you for showing your interest! Feel free to start working on this issue! (please note that it may take some time to merge your PR because the next 1.7 release is getting very close.)

[haesungpyun]

Hello, I have an problem while renaming ProgressBarBase to ProgressBar.
There's a conflict in src/pytorch_lightning/callbacks/progress/rich_progress.py in 23 line and 33 line if ProgressBarBase renamed to ProgressBar.
The code use ProgressBar from rich package progress_bar.py. (The part where the error occurred was marked with *)
How should I handle this conflict?
Thank you!

https://github.com/Lightning-AI/lightning/blob/master/src/pytorch_lightning/callbacks/progress/rich_progress.py

import pytorch_lightning as pl
from pytorch_lightning.callbacks.progress.base import ***ProgressBarBase
from pytorch_lightning.utilities.imports import _package_available

_RICH_AVAILABLE: bool = _package_available("rich") and _compare_version("rich", operator.ge, "10.2.2")

Task, Style = None, None
if _RICH_AVAILABLE:
    from rich import get_console, reconfigure
    from rich.console import RenderableType
    from rich.progress import BarColumn, Progress, ProgressColumn, Task, TaskID, TextColumn
    from rich.progress_bar import ***ProgressBar
    from rich.style import Style
    from rich.text import Text

[sparkyniner]

Hello, can I work on this issue?

[carmocca]

If this doesn't land for 2.0, it will likely not happen. Is anybody interested in gettting this done quickly?

[tshu-w]

@carmocca Hi, I make a quick replacement in #17058, I will check the test and doc tomorrow.