Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename loops/base.py to loops/loop.py #11974

Closed
daniellepintz opened this issue Feb 18, 2022 · 3 comments · Fixed by #13043
Closed

Rename loops/base.py to loops/loop.py #11974

daniellepintz opened this issue Feb 18, 2022 · 3 comments · Fixed by #13043
Labels
good first issue Good for newcomers help wanted Open to be worked on loops Related to the Loop API refactor
Milestone
pl:1.7

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Feb 18, 2022 •
edited by github-actions bot
Loading

Proposed refactor

Rename loops/base.py to loops/loop.py

Motivation

For consistency, let's conform to the standard of our other main files, like accelerators/accelerator.py and strategies/strategy.py.

Part of #11908

cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca @ananthsub @ninginthecloud @daniellepintz
@daniellepintz daniellepintz added help wanted Open to be worked on refactor loops Related to the Loop API labels Feb 18, 2022
@ananthsub ananthsub added the good first issue Good for newcomers label Feb 18, 2022
@valanm22 valanm22 mentioned this issue Feb 18, 2022
Closed
12 tasks
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Apr 17, 2022
@daniellepintz daniellepintz removed the won't fix This will not be worked on label Apr 18, 2022
@awaelchli awaelchli added this to the 1.7 milestone Apr 25, 2022
@kingjuno
Copy link
Contributor

@valanm22 Can I start working on this issue if you are not working on this now?

@valanm22
Copy link

Yes @kingjuno you can.

@kingjuno kingjuno mentioned this issue May 12, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Open to be worked on loops Related to the Loop API refactor
Projects
None yet
Milestone
pl:1.7
5 participants
@ananthsub @awaelchli @daniellepintz @kingjuno @valanm22