Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename loops/base.py to loops/loop.py #13043

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Rename loops/base.py to loops/loop.py #13043

merged 2 commits into from
Jun 2, 2022

Conversation

kingjuno
Copy link
Contributor

@kingjuno kingjuno commented May 12, 2022 •
edited by carmocca
Loading

What does this PR do?

Fixes #11974

IMPORTANT: This PR needs to be "Rebase and Merge"d. Do not add merge commits!

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kingjuno
Copy link
Contributor Author

@daniellepintz can you please take a look?

@carmocca carmocca added this to the 1.7 milestone May 12, 2022
@carmocca carmocca added deprecation Includes a deprecation loops Related to the Loop API community This PR is from the community labels May 12, 2022
@carmocca carmocca self-assigned this May 12, 2022
carmocca added a commit to kingjuno/pytorch-lightning that referenced this pull request Jun 1, 2022
@carmocca
Rename loops/base.py to loops/loop.py (Lightning-AI#13043)
5a03700
@mergify mergify bot removed the has conflicts label Jun 1, 2022
carmocca added a commit to kingjuno/pytorch-lightning that referenced this pull request Jun 1, 2022
@carmocca
Add deprecation path for the old Loop module (Lightning-AI#13043)
00b25e2
@carmocca carmocca changed the title Rename base.py to loop.py Rename loops/base.py to loops/loop.py Jun 1, 2022
@carmocca carmocca enabled auto-merge (rebase) June 1, 2022 11:59
@mergify mergify bot added the ready PRs ready to be merged label Jun 1, 2022
@carmocca carmocca requested a review from akihironitta June 1, 2022 12:01
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 2, 2022
carmocca added a commit to kingjuno/pytorch-lightning that referenced this pull request Jun 2, 2022
@carmocca
Add deprecation path for the old Loop module (Lightning-AI#13043)
2e0c13a
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 2, 2022
akihironitta
akihironitta approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment below, LGTM!

CHANGELOG.md Show resolved Hide resolved
@Borda Borda added the breaking change Includes a breaking change label Jun 2, 2022
@carmocca carmocca removed the breaking change Includes a breaking change label Jun 2, 2022
@carmocca
Copy link
Contributor

carmocca commented Jun 2, 2022

@Borda this is not a breaking change. A deprecation path was added.

@carmocca carmocca merged commit 7938293 into Lightning-AI:master Jun 2, 2022
carmocca added a commit that referenced this pull request Jun 2, 2022
@carmocca
Rename loops/base.py to loops/loop.py (#13043)
a8a6a5b
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees

@carmocca carmocca

Labels
community This PR is from the community deprecation Includes a deprecation loops Related to the Loop API ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.

Rename loops/base.py to loops/loop.py
4 participants
@kingjuno @carmocca @Borda @akihironitta