-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ProgressBarBase
to ProgressBar
#17058
Conversation
Should I rename |
Yes please |
ProgressBarBase
to ProgressBar
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #17058 +/- ##
=========================================
- Coverage 82% 79% -3%
=========================================
Files 436 418 -18
Lines 31739 31546 -193
=========================================
- Hits 25985 24845 -1140
- Misses 5754 6701 +947 |
ProgressBarBase
to ProgressBar
ProgressBarBase
to ProgressBar
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changelog
Congratulations on the release of Lightning 2.0! I can't wait to update and try it out. @awaelchli However, I noticed that some contributors seem to be missing from the releases page, and I feel a little loss not seeing myself included in such a significant update. |
Hey @tshu-w I will make sure you are included and I'll rerun the script fetching the contributors to make sure nobody gets missed. |
What does this PR do?
Fixes #11908
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist