Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ProgressBarBase to ProgressBar #17058

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Rename ProgressBarBase to ProgressBar #17058

merged 3 commits into from
Mar 14, 2023

Conversation

tshu-w
Copy link
Contributor

@tshu-w tshu-w commented Mar 13, 2023

What does this PR do?

Fixes #11908

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 13, 2023
@tshu-w
Copy link
Contributor Author

tshu-w commented Mar 13, 2023

Should I rename progress/base.py to progress_bar.py?

@carmocca
Copy link
Contributor

Yes please

@carmocca carmocca added refactor callback breaking change Includes a breaking change labels Mar 13, 2023
@carmocca carmocca added this to the 2.0 milestone Mar 13, 2023
@carmocca carmocca added the community This PR is from the community label Mar 13, 2023
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Mar 13, 2023
@tshu-w tshu-w changed the title rename ProgressBarBase to ProgressBar rename ProgressBarBase to ProgressBar Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #17058 (39d8763) into master (c93952c) will decrease coverage by 3%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #17058     +/-   ##
=========================================
- Coverage      82%      79%     -3%     
=========================================
  Files         436      418     -18     
  Lines       31739    31546    -193     
=========================================
- Hits        25985    24845   -1140     
- Misses       5754     6701    +947     

@awaelchli awaelchli changed the title rename ProgressBarBase to ProgressBar Rename ProgressBarBase to ProgressBar Mar 14, 2023
@awaelchli
Copy link
Contributor

Thanks!

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changelog

@mergify mergify bot added the ready PRs ready to be merged label Mar 14, 2023
@carmocca carmocca enabled auto-merge (squash) March 14, 2023 13:03
@carmocca carmocca merged commit f3a20d0 into Lightning-AI:master Mar 14, 2023
@tshu-w
Copy link
Contributor Author

tshu-w commented Mar 15, 2023

Congratulations on the release of Lightning 2.0! I can't wait to update and try it out.

@awaelchli However, I noticed that some contributors seem to be missing from the releases page, and I feel a little loss not seeing myself included in such a significant update.

@awaelchli
Copy link
Contributor

Hey @tshu-w I will make sure you are included and I'll rerun the script fetching the contributors to make sure nobody gets missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package breaking change Includes a breaking change callback community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ProgressBarBase to ProgressBar
5 participants