Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO tracker for ongoing training loop refactors #7938

Closed
13 of 14 tasks
awaelchli opened this issue Jun 11, 2021 · 1 comment
Closed
13 of 14 tasks

TODO tracker for ongoing training loop refactors #7938

awaelchli opened this issue Jun 11, 2021 · 1 comment
Assignees
Labels
docs Documentation related feature Is an improvement or enhancement let's do it! approved to implement refactor
Milestone

Comments

@awaelchli
Copy link
Contributor

awaelchli commented Jun 11, 2021

📚 TODOs around the loop refactor

This issue tracks the work planned for and after the loop refactor #7700.
Core contributors feel free to update the description here directly.

Hygiene and code quality

  • Typing for full mypy compatibility (see ignored files in setup.cfg)
  • Documentation for the public interface + address [Refactor] Remove _run_evaluation + 3 EvaluationLoop #8065 (comment)
  • Evaluate which methods should be public and which should be protected
  • Rename Trainer.train_loop to Trainer.fit_loop and deprecate the former access.
  • Formalize how arguments are forwarded to lower loops (especially in connect

Feature integration and follow-up refactors

Customization

Miscellaneous

cc: @justusschock @carmocca @ananthsub @tchaton

@awaelchli awaelchli added docs Documentation related productivity refactor feature Is an improvement or enhancement priority: 1 Medium priority task and removed priority: 1 Medium priority task labels Jun 11, 2021
@awaelchli awaelchli added this to the v1.4 milestone Jun 11, 2021
@edenlightning edenlightning modified the milestones: v1.4, v1.5 Jul 6, 2021
@tchaton tchaton added the let's do it! approved to implement label Sep 9, 2021
@awaelchli awaelchli modified the milestones: v1.5, v1.6 Nov 4, 2021
@carmocca
Copy link
Contributor

carmocca commented Feb 1, 2022

Closing as everything looks done here

@carmocca carmocca closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related feature Is an improvement or enhancement let's do it! approved to implement refactor
Projects
None yet
Development

No branches or pull requests

5 participants