-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark FitLoop.should_accumulate
as protected
#9515
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix _should_accumultate call
awaelchli
changed the title
Mark
mark Sep 14, 2021
FitLoop.should_accumulate
as protectedFitLoop.should_accumulate
as protected
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
September 15, 2021 09:49
Codecov Report
@@ Coverage Diff @@
## master #9515 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 180 180
Lines 15090 15090
=======================================
- Hits 14019 13404 -615
- Misses 1071 1686 +615 |
SeanNaren
approved these changes
Sep 15, 2021
ethanwharris
approved these changes
Sep 15, 2021
justusschock
approved these changes
Sep 15, 2021
carmocca
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
All methods that are not part of the base loop interface get marked as protected. We want to make these methods protected so custom loop implementations don't rely on them as we will likely push out further refactors around them.
Part of #7938
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃