-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loop specialization #8226
Loop specialization #8226
Conversation
for more information, see https://pre-commit.ci
Hello @awaelchli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-19 11:55:06 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #8226 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 217 217
Lines 14094 14341 +247
=======================================
+ Hits 13001 13236 +235
- Misses 1093 1105 +12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ananthsub @awaelchli, what are your thoughts there ?
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat !
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
What does this PR do?
Enables loop specialization through a connect mechanism.
Three main use cases:
A) Set loop directly on the trainer:
B) Connect child loops to the main loop (nesting):
C) Connect a custom loop to an existing Lightning loop:
Setting the trainer references is handled internally by Lightning. The user does NOT connect the trainer directly to the loop.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃