-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing docstrings to public properties in loggers #9028
Comments
I can do this |
I think this should still be open as the other logger classes are left. |
@bamblebam it was auto-closed. It was because you had "Fixes xyz" in the description of the PR, GitHub was smart about it to close after merge :) |
Since the doc strings in other logger classes have been updated is this issue done or do we need to update the base logger class as well. |
Thanks a lot. |
📚 Documentation
There are a few undocumented public properties in the logger wrappers.
Example:
https://github.com/PyTorchLightning/pytorch-lightning/blob/92e49795e1e044ee7f1ca450babf0c50c1b5d81f/pytorch_lightning/loggers/mlflow.py#L174
Let's document these so they show up in our HTML docs and so users can discover them.
This is a good issue for new contributors!! If you are interested, please send a pull request right away (one per logger class).
The text was updated successfully, but these errors were encountered: