-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added doc strings to base logger file #9232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor formatting suggestions 😃
Codecov Report
@@ Coverage Diff @@
## master #9232 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 176 176
Lines 14805 14807 +2
=======================================
- Hits 13658 13043 -615
- Misses 1147 1764 +617 |
tchaton
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Borda
approved these changes
Sep 2, 2021
justusschock
added a commit
that referenced
this pull request
Sep 7, 2021
* added doc strings to base logger * updated docs
Borda
pushed a commit
that referenced
this pull request
Sep 7, 2021
* added doc strings to base logger * updated docs
awaelchli
pushed a commit
that referenced
this pull request
Sep 7, 2021
* added doc strings to base logger * updated docs
lexierule
pushed a commit
that referenced
this pull request
Sep 10, 2021
* added doc strings to base logger * updated docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Links #9028
Added doc strings to the base logger file
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃