Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc strings to base logger file #9232

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

bamblebam
Copy link
Contributor

What does this PR do?

Links #9028
Added doc strings to the base logger file

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor formatting suggestions 😃

pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #9232 (72435f5) into master (f6614b3) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9232    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         176     176            
  Lines       14805   14807     +2     
=======================================
- Hits        13658   13043   -615     
- Misses       1147    1764   +617     

@ethanwharris ethanwharris added the docs Documentation related label Sep 1, 2021
@ethanwharris ethanwharris added this to the v1.4.x milestone Sep 1, 2021
@ethanwharris ethanwharris added the logger Related to the Loggers label Sep 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 1, 2021
@mergify mergify bot requested a review from a team September 1, 2021 10:13
@Borda Borda merged commit ead2404 into Lightning-AI:master Sep 2, 2021
justusschock added a commit that referenced this pull request Sep 7, 2021
* added doc strings to base logger

* updated docs
Borda pushed a commit that referenced this pull request Sep 7, 2021
* added doc strings to base logger

* updated docs
awaelchli pushed a commit that referenced this pull request Sep 7, 2021
* added doc strings to base logger

* updated docs
lexierule pushed a commit that referenced this pull request Sep 10, 2021
* added doc strings to base logger

* updated docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants