Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc strings to wandb logger #9109

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

bamblebam
Copy link
Contributor

@bamblebam bamblebam commented Aug 25, 2021

What does this PR do?

Links #9028
Adds docstrings in the wandb logger class.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@bamblebam
Copy link
Contributor Author

Does this need to be more verbose, because I think it should but I don't know how.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #9109 (ce6993a) into master (1a2468f) will decrease coverage by 4%.
The diff coverage is n/a.

❗ Current head ce6993a differs from pull request most recent head d7c8352. Consider uploading reports for the commit d7c8352 to get more accurate results

@@           Coverage Diff           @@
##           master   #9109    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         178     176     -2     
  Lines       14694   14666    -28     
=======================================
- Hits        13526   12889   -637     
- Misses       1168    1777   +609     

pytorch_lightning/loggers/wandb.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/wandb.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added logger Related to the Loggers docs Documentation related labels Aug 25, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 25, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) August 26, 2021 08:59
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2021
@mergify mergify bot requested a review from a team August 26, 2021 08:59
@tchaton tchaton merged commit b576201 into Lightning-AI:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants