Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated on_keyboard_interrupt #13438

Merged
merged 16 commits into from
Jul 5, 2022
Merged

Remove deprecated on_keyboard_interrupt #13438

merged 16 commits into from
Jul 5, 2022

Conversation

nitinramvelraj
Copy link
Contributor

@nitinramvelraj nitinramvelraj commented Jun 28, 2022 •
edited by Borda
Loading

What does this PR do?

Part of #12521. Removes code relating to on_keyboard_interrupt.

resolves #9260

Does your PR introduce any breaking changes? If yes, please list them.

Removes Callback.on_keyboard_interrupt in favour of Callback.on_exception.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes

Make sure you had fun coding 🙃

@nitinramvelraj nitinramvelraj marked this pull request as draft June 28, 2022 19:28
@akihironitta akihironitta added callback breaking change Includes a breaking change community This PR is from the community labels Jun 29, 2022
@akihironitta akihironitta changed the title Remove deprecated code after the 1.6 release #12521 - on_keyboard_interrupt deprecation Remove deprecated on_keyboard_interrupt Jun 29, 2022
@akihironitta akihironitta added this to the pl:1.7 milestone Jun 29, 2022
akihironitta
akihironitta reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nitinramvelraj Thank you for reaching out to me via Slack! Could you update the changelog? Once it's added and all tests pass, this PR should be ready for merge :)

@akihironitta akihironitta self-assigned this Jun 29, 2022
@nitinramvelraj
Copy link
Contributor Author

Put an entry on the changelog! Thanks for all the help! This was a great learning exp!

@nitinramvelraj nitinramvelraj marked this pull request as ready for review June 29, 2022 16:03
@akihironitta akihironitta self-requested a review June 29, 2022 16:19
akihironitta
akihironitta approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Thank you for your first contribution! 🚀

src/lightning_app/utilities/introspection.py Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes Jun 30, 2022
View reviewed changes
tests/tests_pytorch/trainer/test_states.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jun 30, 2022
@awaelchli awaelchli enabled auto-merge (squash) July 2, 2022 00:24
@awaelchli awaelchli disabled auto-merge July 5, 2022 06:23
@awaelchli awaelchli enabled auto-merge (squash) July 5, 2022 06:23
@awaelchli awaelchli merged commit 61c28cb into Lightning-AI:master Jul 5, 2022
@akihironitta akihironitta mentioned this pull request Jul 6, 2022
Closed
44 tasks
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@nitinramvelraj @akihironitta
@carmocca @awaelchli @jerome-habana
Remove deprecated on_keyboard_interrupt (Lightning-AI#13438)
5dc9538 
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@akihironitta akihironitta

Labels
breaking change Includes a breaking change callback community This PR is from the community ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@nitinramvelraj @awaelchli @carmocca @akihironitta