-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate on_keyboard_interrupt
callback hook
#9260
Conversation
for more information, see https://pre-commit.ci
…ning into on_exception
for more information, see https://pre-commit.ci
…ning into dep_keyboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMTG
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
…ning into dep_keyboard
Waiting to merge - will incorporate fix for #9286 |
there are still some failing tests, mind have look? |
Codecov Report
@@ Coverage Diff @@
## master #9260 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 176 178 +2
Lines 14810 14854 +44
=======================================
- Hits 13662 13093 -569
- Misses 1148 1761 +613 |
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
on_keyboard_interrupt
callback hook
What does this PR do?
This callback hook will be subsumed by the new on_exception hook (#9183).
The PR includes small addition to the is_overridden helper function, to automatically set the parent to Callback if a Callback instance is passed, which made changes to configuration_validator.py simpler.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃