-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce primitives for input/output dtype conversion in Lite Precision #14792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
commented
Sep 21, 2022
awaelchli
commented
Sep 21, 2022
awaelchli
commented
Sep 21, 2022
awaelchli
added
fabric
lightning.fabric.Fabric
feature
Is an improvement or enhancement
refactor
labels
Sep 21, 2022
carmocca
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged #14823
carmocca
reviewed
Sep 22, 2022
awaelchli
requested review from
justusschock,
tchaton and
kaushikb11
as code owners
September 22, 2022 13:57
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
carmocca
reviewed
Sep 22, 2022
11 tasks
carmocca
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving after the latest changes
awaelchli
commented
Sep 29, 2022
otaj
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Precision plugin exposes API to convert model input and outputs to the appropriate precision dtype.
Note that this is just for Lite for now, as precision integration in PL is still ongoing.
Follow up to #14815
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca @akihironitta