Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce primitives for input/output dtype conversion in Lite Precision #14792

Merged
merged 18 commits into from
Sep 30, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 19, 2022

What does this PR do?

The Precision plugin exposes API to convert model input and outputs to the appropriate precision dtype.
Note that this is just for Lite for now, as precision integration in PL is still ongoing.

Follow up to #14815

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 19, 2022
@awaelchli awaelchli added fabric lightning.fabric.Fabric feature Is an improvement or enhancement refactor labels Sep 21, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 21, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged #14823

src/lightning_lite/plugins/precision/deepspeed.py Outdated Show resolved Hide resolved
@awaelchli awaelchli marked this pull request as ready for review September 22, 2022 13:57
src/lightning_lite/connector.py Outdated Show resolved Hide resolved
src/lightning_lite/plugins/precision/deepspeed.py Outdated Show resolved Hide resolved
src/lightning_lite/plugins/precision/precision.py Outdated Show resolved Hide resolved
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
@mergify mergify bot removed the has conflicts label Sep 22, 2022
@awaelchli awaelchli self-assigned this Sep 26, 2022
@mergify mergify bot removed the has conflicts label Sep 27, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after the latest changes

@mergify mergify bot added the ready PRs ready to be merged label Sep 30, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 30, 2022 11:26
@awaelchli awaelchli merged commit cd9247a into master Sep 30, 2022
@awaelchli awaelchli deleted the lite/dtype-conversion branch September 30, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants