Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for Precision in Lite #14815

Merged
merged 51 commits into from
Sep 26, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 20, 2022

What does this PR do?

Converts the precision plugin integration tests from PL to Lite tests where applicable.
The tests can be classified into three groups (annotated in code for review):

  • adopted: This test was fully or partially adopted into Lite
  • skipped: The test is legacy or questionable whether it is of any use at all
  • unimplemented: This test covers functionality only available in Trainer, and can't be ported to Lite. Example: Apex

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @carmocca @justusschock @awaelchli @Borda @akihironitta @rohitgr7

@awaelchli awaelchli self-assigned this Sep 20, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 20, 2022
@awaelchli awaelchli removed the pl Generic label for PyTorch Lightning package label Sep 20, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 26, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 26, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 26, 2022 16:01
@awaelchli awaelchli merged commit d7404c7 into master Sep 26, 2022
@awaelchli awaelchli deleted the lite/integration-tests branch September 26, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric precision: amp Automatic Mixed Precision precision: double Double precision ready PRs ready to be merged tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants