Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairscale integration tests for Lite #14921

Merged
merged 16 commits into from
Sep 29, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 28, 2022

What does this PR do?

Analogous to #14901 and #14815

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @carmocca @justusschock @awaelchli @Borda @akihironitta @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 28, 2022
@awaelchli awaelchli added fabric lightning.fabric.Fabric tests strategy: fairscale sharded (removed) Sharded Data Parallel and removed pl Generic label for PyTorch Lightning package labels Sep 28, 2022
@awaelchli awaelchli self-assigned this Sep 28, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 28, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 28, 2022
@awaelchli awaelchli force-pushed the lite/integration-tests-sharded branch from 1d5bf3c to 6fff52d Compare September 28, 2022 16:58
src/lightning_lite/lite.py Outdated Show resolved Hide resolved
src/lightning_lite/strategies/fairscale.py Show resolved Hide resolved
debug

debug

debug

debug

debug

debug

debug

debug

debug

debug

debug

debug

debug

debug

update


debug

comment
@mergify mergify bot added the ready PRs ready to be merged label Sep 29, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 29, 2022 15:56
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 29, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 29, 2022
@awaelchli awaelchli merged commit 498cb60 into master Sep 29, 2022
@awaelchli awaelchli deleted the lite/integration-tests-sharded branch September 29, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: fairscale sharded (removed) Sharded Data Parallel tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants