Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inference_mode flag to Trainer #15034

Merged
merged 41 commits into from
Oct 12, 2022
Merged

Add inference_mode flag to Trainer #15034

merged 41 commits into from
Oct 12, 2022

Conversation

rschireman
Copy link
Contributor

@rschireman rschireman commented Oct 7, 2022 •
edited
Loading

What does this PR do?

Fixes #14497 by adding a flag to the trainer to control the behavior of autograd in inference mode, such as during model testing.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • [] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 7, 2022
@rschireman rschireman marked this pull request as ready for review October 7, 2022 20:46
rohitgr7
rohitgr7 reviewed Oct 8, 2022
View reviewed changes
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
tests/tests_pytorch/trainer/flags/test_inference_grad_mode.py Outdated Show resolved Hide resolved
Raymond G Schireman and others added 5 commits October 10, 2022 21:30
@mergify mergify bot added the ready PRs ready to be merged label Oct 10, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 10, 2022 23:07
@rohitgr7 rohitgr7 changed the title Add eval_inference_mode flag to Trainer Add inference_mode flag to Trainer Oct 10, 2022
@rohitgr7 rohitgr7 disabled auto-merge October 10, 2022 23:07
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 10, 2022 23:07
@rohitgr7 rohitgr7 added this to the v1.8 milestone Oct 12, 2022
@rohitgr7 rohitgr7 merged commit 0a5e75e into Lightning-AI:master Oct 12, 2022
@akihironitta akihironitta mentioned this pull request Oct 12, 2022
Closed
12 tasks
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@rschireman @rohitgr7
@carmocca @Borda @nicolai86
Add inference_mode flag to Trainer (#15034)
a4b32e6 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@rohitgr7 rohitgr7 mentioned this pull request Oct 17, 2022
Closed
@rschireman rschireman mentioned this pull request Oct 20, 2022
Closed
12 tasks
@KnathanM KnathanM mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@otaj otaj Awaiting requested review from otaj

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@rohitgr7 rohitgr7

Labels
community This PR is from the community feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged trainer: argument
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Need an option for evaluation not in the inference_mode.
5 participants
@rschireman @awaelchli @Borda @carmocca @rohitgr7