Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype for MPS in reinforcement learning example #19982

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

swyo
Copy link
Contributor

@swyo swyo commented Jun 17, 2024

What does this PR do?

Fixes #19981

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
The only part I am modifying is the example code, so there are no other dependencies affected by this change.


📚 Documentation preview 📚: https://pytorch-lightning--19982.org.readthedocs.build/en/19982/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 17, 2024
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

examples/fabric/reinforcement_learning/train_fabric.py Outdated Show resolved Hide resolved
@awaelchli awaelchli changed the title fix example for mps; issue #19981 Fix dtype for MPS in reinforcement example Jun 17, 2024
@awaelchli awaelchli changed the title Fix dtype for MPS in reinforcement example Fix dtype for MPS in reinforcement learning example Jun 17, 2024
@awaelchli awaelchli added this to the 2.4 milestone Jun 17, 2024
@awaelchli awaelchli merged commit d3a0ada into Lightning-AI:master Jun 21, 2024
13 checks passed
@swyo swyo deleted the fabric/example/rl-for-mps branch June 22, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example fabric lightning.fabric.Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fabric.example.rl] Not support torch.float64 for MPS device
2 participants