[feat] Logging refactor 2/n - train #4495

tchaton · 2020-11-03T10:48:10Z

What does this PR do?

This PR introduces enables logic to log within callback for training only for now.

Next PR will enable the same for evaluation.

Fixes # (issue)

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
Did you make sure to update the documentation with your changes?
Did you write any new necessary tests?
Did you verify new and existing tests pass locally with your changes?
If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

…ing/pytorch-lightning into feat/train_logging

tests/trainer/logging/test_logger_connector.py

SeanNaren

A few nits, but on par great work! I'll take a further deep dive later.

pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py

pytorch_lightning/trainer/evaluation_loop.py

Borda

still reading the bigger picture... :]

pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py

pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py

pytorch_lightning/trainer/training_loop.py

pep8speaks · 2020-11-03T14:21:16Z

Hello @tchaton! Thanks for updating this PR.

In the file tests/trainer/logging/test_logger_connector.py:

Line 356:13: W503 line break before binary operator
Line 357:13: W503 line break before binary operator
Line 358:13: W503 line break before binary operator
Line 359:13: W503 line break before binary operator
Line 363:13: W503 line break before binary operator
Line 364:13: W503 line break before binary operator

In the file tests/trainer/logging_tests/test_train_loop_logging_1_0.py:

Line 523:121: E501 line too long (124 > 120 characters)

Comment last updated at 2020-11-05 21:47:06 UTC

pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

Borda

still reading... :]

pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py

tests/trainer/legacy_deprecate_flow_log_tests/test_eval_loop_dict_return.py

…ing/pytorch-lightning into feat/train_logging

…sult_store.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Borda

LGTM

pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py

pytorch_lightning/trainer/evaluation_loop.py

tests/trainer/logging/test_logger_connector.py

tests/trainer/logging_tests/test_distributed_logging.py

tests/trainer/logging_tests/test_train_loop_logging_1_0.py

Borda · 2020-11-05T17:31:34Z

@tchaton have you check why the tests are failing? :]

…sult_store.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

…ing/pytorch-lightning into feat/train_logging

teddykoker

LGTM 🎉

…ing/pytorch-lightning into feat/train_logging

* update logging * solve more bugs * replace Mapping by Dict * update on comments * resolve pep8 * Apply suggestions from code review Co-authored-by: ananthsub <ananth.subramaniam@gmail.com> * Update pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * update on comments * typo * update for coverage * update test * update * Update tests/models/test_hooks.py Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> * Update tests/models/test_hooks.py Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> * update on comments * remove deepcopy * remove useless look for * another small optim * extra optim * remove lastest optim, can be source of bug * resolve bug * add docstring * optimize coverage * Update pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update tests/trainer/logging_tests/test_distributed_logging.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/trainer/evaluation_loop.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update tests/trainer/logging/test_logger_connector.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update tests/trainer/logging_tests/test_train_loop_logging_1_0.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * update on comments * update * update on comments * update parity speed * get it down to 0.65 * update * 0.8 max_dif Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: ananthsub <ananth.subramaniam@gmail.com> Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: William Falcon <waf2107@columbia.edu>

update logging

2b3c4bc

tchaton requested review from ananyahjha93, awaelchli, Borda, justusschock, nateraw, SeanNaren, teddykoker and williamFalcon as code owners November 3, 2020 10:48

tchaton added 5 commits November 3, 2020 10:48

Merge branch 'master' into feat/train_logging

e2814ad

Merge branch 'master' into feat/train_logging

f487a5d

solve more bugs

ba0427f

Merge branch 'feat/train_logging' of https://github.com/PyTorchLightn…

c68995a

…ing/pytorch-lightning into feat/train_logging

replace Mapping by Dict

8337394

Borda reviewed Nov 3, 2020

View reviewed changes

tests/trainer/logging/test_logger_connector.py Outdated Show resolved Hide resolved

SeanNaren reviewed Nov 3, 2020

View reviewed changes

pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py Outdated Show resolved Hide resolved

pytorch_lightning/trainer/evaluation_loop.py Outdated Show resolved Hide resolved

Borda reviewed Nov 3, 2020

View reviewed changes

Borda mentioned this pull request Nov 3, 2020

feature: Add logging test / val callback functions #4351

Closed

8 tasks

update on comments

3862ef7

resolve pep8

23a62ac

ananthsub reviewed Nov 3, 2020

View reviewed changes

pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py Outdated Show resolved Hide resolved

Merge branch 'master' into feat/train_logging

ebf6573

edenlightning mentioned this pull request Nov 3, 2020

loss=None and no logs when automatic_optimization=False #4204

Closed

Apply suggestions from code review

3921725

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

Borda reviewed Nov 4, 2020

View reviewed changes

tchaton and others added 4 commits November 4, 2020 08:51

Merge branch 'master' into feat/train_logging

09ace23

Merge branch 'feat/train_logging' of https://github.com/PyTorchLightn…

c9308d4

…ing/pytorch-lightning into feat/train_logging

Update pytorch_lightning/trainer/connectors/logger_connector/epoch_re…

e459131

…sult_store.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Merge branch 'master' into feat/train_logging

abd0fc0

Borda approved these changes Nov 5, 2020

View reviewed changes

tchaton and others added 11 commits November 5, 2020 17:58

Update pytorch_lightning/trainer/connectors/logger_connector/epoch_re…

aa393c3

…sult_store.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Update pytorch_lightning/trainer/connectors/logger_connector/epoch_re…

bc62cff

…sult_store.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Update tests/trainer/logging_tests/test_distributed_logging.py

85317ad

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Update pytorch_lightning/trainer/evaluation_loop.py

d492d94

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Update tests/trainer/logging/test_logger_connector.py

caea74c

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Update tests/trainer/logging_tests/test_train_loop_logging_1_0.py

5bc3847

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Merge branch 'master' into feat/train_logging

66a89a8

update on comments

6c7373a

Merge branch 'feat/train_logging' of https://github.com/PyTorchLightn…

60f95a8

…ing/pytorch-lightning into feat/train_logging

update

ef2065c

update on comments

6a9bcc5

tchaton added the ready PRs ready to be merged label Nov 5, 2020

tchaton added 3 commits November 5, 2020 19:37

update parity speed

e22d9f8

get it down to 0.65

395df7f

update

ae64091

teddykoker approved these changes Nov 5, 2020

View reviewed changes

williamFalcon and others added 3 commits November 5, 2020 16:07

Merge branch 'master' into feat/train_logging

59ca975

0.8 max_dif

4c19f96

Merge branch 'feat/train_logging' of https://github.com/PyTorchLightn…

c86643b

…ing/pytorch-lightning into feat/train_logging

tchaton merged commit 9c8701f into master Nov 5, 2020

tchaton deleted the feat/train_logging branch November 5, 2020 22:27

tchaton restored the feat/train_logging branch November 5, 2020 22:31

tchaton deleted the feat/train_logging branch November 5, 2020 22:31

tchaton restored the feat/train_logging branch November 5, 2020 22:31

Borda mentioned this pull request Nov 6, 2020

[FEAT] Refactor logging 3/3 [v1] #4552

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] Logging refactor 2/n - train #4495

[feat] Logging refactor 2/n - train #4495

tchaton commented Nov 3, 2020 •

edited

Loading

SeanNaren left a comment

Borda left a comment

pep8speaks commented Nov 3, 2020 •

edited

Loading

Borda left a comment

Borda left a comment

Borda commented Nov 5, 2020

teddykoker left a comment

[feat] Logging refactor 2/n - train #4495

[feat] Logging refactor 2/n - train #4495

Conversation

tchaton commented Nov 3, 2020 • edited Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

SeanNaren left a comment

Choose a reason for hiding this comment

Borda left a comment

Choose a reason for hiding this comment

pep8speaks commented Nov 3, 2020 • edited Loading

Comment last updated at 2020-11-05 21:47:06 UTC

Borda left a comment

Choose a reason for hiding this comment

Borda left a comment

Choose a reason for hiding this comment

Borda commented Nov 5, 2020

teddykoker left a comment

Choose a reason for hiding this comment

tchaton commented Nov 3, 2020 •

edited

Loading

pep8speaks commented Nov 3, 2020 •

edited

Loading