Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantisation #5706

Merged
merged 48 commits into from
Feb 11, 2021
Merged

Quantisation #5706

merged 48 commits into from
Feb 11, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 29, 2021

What does this PR do?

Resources:

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added feature Is an improvement or enhancement callback labels Jan 29, 2021
@Borda Borda added this to the 1.2 milestone Jan 29, 2021
@Borda Borda self-assigned this Jan 30, 2021
@Borda Borda force-pushed the feat/quantization branch from 1003083 to c659750 Compare February 1, 2021 16:05
@Borda Borda changed the title Quantization Quantisation [wip] Feb 1, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 5, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-11 11:21:09 UTC

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #5706 (c646e3d) into release/1.2-dev (9475c84) will decrease coverage by 0%.
The diff coverage is 71%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5706    +/-   ##
================================================
- Coverage               88%     88%    -0%     
================================================
  Files                  182     184     +2     
  Lines                13082   13191   +109     
================================================
+ Hits                 11576   11624    +48     
- Misses                1506    1567    +61     

@Borda Borda marked this pull request as ready for review February 5, 2021 09:54
@Borda Borda changed the title Quantisation [wip] Quantisation Feb 5, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and amazing new feature !

pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Show resolved Hide resolved
pytorch_lightning/core/lightning.py Show resolved Hide resolved
tests/callbacks/test_quantization.py Outdated Show resolved Hide resolved
tests/callbacks/test_quantization.py Show resolved Hide resolved
@Borda
Copy link
Member Author

Borda commented Feb 7, 2021

fyi, moving adding the new models to #5861

@Borda Borda force-pushed the feat/quantization branch from 07c59ea to 498ee2b Compare February 7, 2021 20:53
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mix of comments :]

Makefile Outdated Show resolved Hide resolved
@Borda Borda force-pushed the feat/quantization branch from cb8dc27 to 92f8cfb Compare February 8, 2021 11:05
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Outdated Show resolved Hide resolved
tests/callbacks/test_pruning.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/quantization.py Show resolved Hide resolved
tests/callbacks/test_quantization.py Outdated Show resolved Hide resolved
tests/callbacks/test_quantization.py Outdated Show resolved Hide resolved
Borda and others added 20 commits February 11, 2021 11:26
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda Borda force-pushed the feat/quantization branch from a9a7f51 to 1379621 Compare February 11, 2021 10:31
@mergify mergify bot removed the has conflicts label Feb 11, 2021
Makefile Outdated Show resolved Hide resolved
@Borda Borda disabled auto-merge February 11, 2021 11:13
@Borda Borda enabled auto-merge (squash) February 11, 2021 11:14
@Borda Borda force-pushed the feat/quantization branch from 189cd59 to b76eee5 Compare February 11, 2021 11:21
@Borda Borda merged commit b434c47 into release/1.2-dev Feb 11, 2021
@Borda Borda deleted the feat/quantization branch February 11, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants