-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor simplify tests #5861
Refactor simplify tests #5861
Conversation
Hello @Borda! Thanks for updating this PR.
Comment last updated at 2021-02-07 20:06:37 UTC |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5861 +/- ##
================================================
- Coverage 88% 88% -0%
================================================
Files 181 181
Lines 12929 12760 -169
================================================
- Hits 11425 11244 -181
- Misses 1504 1516 +12 |
What's the point of the |
I feel like it was confusing name and also separate the items which will go further from deprecated EvalModule which shall be removed, so what left in base shall be dropped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ! Awesome contrib.
What does this PR do?
move functions to helpers and create Simple regression and classification model
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃