Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor simplify tests #5861

Merged
merged 7 commits into from
Feb 8, 2021
Merged

Refactor simplify tests #5861

merged 7 commits into from
Feb 8, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 7, 2021

What does this PR do?

move functions to helpers and create Simple regression and classification model

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added feature Is an improvement or enhancement ci Continuous Integration refactor labels Feb 7, 2021
@Borda Borda added this to the 1.2 milestone Feb 7, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 7, 2021

Hello @Borda! Thanks for updating this PR.

Line 164:100: W292 no newline at end of file

Line 258:27: W292 no newline at end of file

Comment last updated at 2021-02-07 20:06:37 UTC

@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #5861 (1119a6b) into release/1.2-dev (42812bb) will decrease coverage by 0%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.2-dev   #5861    +/-   ##
================================================
- Coverage               88%     88%    -0%     
================================================
  Files                  181     181            
  Lines                12929   12760   -169     
================================================
- Hits                 11425   11244   -181     
- Misses                1504    1516    +12     

@Borda Borda marked this pull request as ready for review February 7, 2021 18:05
@Borda Borda enabled auto-merge (squash) February 7, 2021 18:05
@Borda Borda mentioned this pull request Feb 7, 2021
12 tasks
@Borda Borda self-assigned this Feb 7, 2021
tests/helpers/test_models.py Show resolved Hide resolved
@carmocca
Copy link
Contributor

carmocca commented Feb 8, 2021

What's the point of the base -> helpers rename?

@Borda
Copy link
Member Author

Borda commented Feb 8, 2021

What's the point of the base -> helpers rename?

I feel like it was confusing name and also separate the items which will go further from deprecated EvalModule which shall be removed, so what left in base shall be dropped

@Borda Borda added the ready PRs ready to be merged label Feb 8, 2021
@mergify mergify bot added the has conflicts label Feb 8, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Awesome contrib.

@Borda Borda merged commit bd920b4 into release/1.2-dev Feb 8, 2021
@Borda Borda deleted the refactor/tests branch February 8, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants