Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINER has been deprecated #7683

Merged
merged 1 commit into from
May 24, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented May 24, 2021

What does this PR do?

Docker Docs

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #7683 (94e75ec) into master (3f460b1) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7683    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         199     199            
  Lines       12956   12957     +1     
=======================================
- Hits        11987   11368   -619     
- Misses        969    1589   +620     

@kaushikb11 kaushikb11 added the ready PRs ready to be merged label May 24, 2021
@mergify mergify bot requested a review from a team May 24, 2021 17:10
@mergify mergify bot requested a review from a team May 24, 2021 17:24
@kaushikb11 kaushikb11 merged commit 2c10ecc into Lightning-AI:master May 24, 2021
@kaushikb11 kaushikb11 deleted the docker/maintainer branch May 24, 2021 18:31
awaelchli added a commit that referenced this pull request May 25, 2021
@Borda Borda mentioned this pull request May 25, 2021
@awaelchli awaelchli added this to the v1.3.x milestone May 25, 2021
Borda pushed a commit that referenced this pull request May 26, 2021
lexierule pushed a commit that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants