Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Patch Release v1.3.3 [full merge, no squash] #7712

Merged
merged 11 commits into from
May 26, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 25, 2021

What does this PR do?

Next patch release after #7589

Related to #7467

gh pr list -s merged -S 'merged:2021-05-19T16:30:00.000Z..2021-05-26T23:30:00.000Z' --json mergedAt,milestone,url,mergeCommit,title --jq 'sort_by(.mergedAt) | reverse | .[] | select((.milestone.title == "v1.3.x") or (.milestone.title == null)) | [.url, .mergeCommit.oid, .title] | join(" ")' --limit 100

ok #7692 8ba6304 Increment the total batch idx before the accumulation early exit
ok #7683 2c10ecc MAINTAINER has been deprecated
no #7676 ad168fc chlog for 1.3.2 + legacy test
ok #7677 8b01497 Fix global step update when the epoch is skipped
ok #7415 3f460b1 Move parameter validation specific to TPU Training plugins
ok #7674 a54bc5d Fix progress bar print error when called before training
ok #7566 0c958c5 Fix dataloaders are not reset when tuning the model
ok #7563 01109cd Fix/mismatched toggle optimizer
no #7639 03ea68f Removed hparams assignment example in doc
ok #7592 92cf396 Override broadcast_object_list for torch<1.8
ok #7608 ed27190 Clear predict_progress_bar in ProgressBar.getstate
no #7606 6e56f56 docker use $(nproc)
no #7598 922c0a6 Fix incorrect code-snippet in optimizers doc

Questions:

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added this to the v1.3.x milestone May 25, 2021
@awaelchli awaelchli changed the base branch from master to release/1.3.x May 25, 2021 22:24
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #7712 (200b5b6) into release/1.3.x (6b81cd8) will decrease coverage by 5%.
The diff coverage is 90%.

@@              Coverage Diff               @@
##           release/1.3.x   #7712    +/-   ##
==============================================
- Coverage             92%     87%    -5%     
==============================================
  Files                200     200            
  Lines              13004   13013     +9     
==============================================
- Hits               11951   11371   -580     
- Misses              1053    1642   +589     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

awaelchli and others added 10 commits May 26, 2021 10:23
Co-authored-by: Yifu Wang <yifuwang@2012@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
* fix: avoid potential mismatched toggling of optimzier
Refs #7405

chore: update CHANGELOG

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

fix: resolve a confict

chore: update changelog

* feat: add a test that fails in master

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix typo in tests/trainer/optimization/test_multiple_optimizers.py

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

* Polish tests/trainer/optimization/test_multiple_optimizers.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Polish tests/trainer/optimization/test_multiple_optimizers.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* fix: change placeholder in optimizer_step from positional args to keyword args

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
fix whitespace


fix parentheses
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
* Check progress bar existence before printing

* Add tests for predict_progres_bar

* Add tests for progress_bar printing without training

* Update changelog
update changelog
* Fix global step update when the epoch is skipped

* Update CHANGELOG

* Move test
* Increment the total batch idx before the accumulation early exit

* Update CHANGELOG
* Move parameter validation specific to TPU Training plugins

* update docstring
@Borda Borda added the ready PRs ready to be merged label May 26, 2021
## [1.3.1] - 2021-05-11


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not blocking) extra whitespace

Suggested change

@carmocca carmocca mentioned this pull request May 26, 2021
@lexierule lexierule merged commit e0850b3 into release/1.3.x May 26, 2021
@lexierule lexierule deleted the v1.3.3 branch May 26, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants