-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly Patch Release v1.3.3 [full merge, no squash] #7712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/1.3.x #7712 +/- ##
==============================================
- Coverage 92% 87% -5%
==============================================
Files 200 200
Lines 13004 13013 +9
==============================================
- Hits 11951 11371 -580
- Misses 1053 1642 +589 |
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
SkafteNicki,
tchaton and
williamFalcon
as code owners
May 25, 2021 23:04
justusschock
approved these changes
May 26, 2021
tchaton
approved these changes
May 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ethanwharris
approved these changes
May 26, 2021
kaushikb11
approved these changes
May 26, 2021
Co-authored-by: Yifu Wang <yifuwang@2012@gmail.com> Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
* fix: avoid potential mismatched toggling of optimzier Refs #7405 chore: update CHANGELOG [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fix: resolve a confict chore: update changelog * feat: add a test that fails in master * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo in tests/trainer/optimization/test_multiple_optimizers.py Co-authored-by: ananthsub <ananth.subramaniam@gmail.com> * Polish tests/trainer/optimization/test_multiple_optimizers.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Polish tests/trainer/optimization/test_multiple_optimizers.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * fix: change placeholder in optimizer_step from positional args to keyword args Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ananthsub <ananth.subramaniam@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> fix whitespace fix parentheses
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
* Check progress bar existence before printing * Add tests for predict_progres_bar * Add tests for progress_bar printing without training * Update changelog update changelog
* Fix global step update when the epoch is skipped * Update CHANGELOG * Move test
* Increment the total batch idx before the accumulation early exit * Update CHANGELOG
for more information, see https://pre-commit.ci
* Move parameter validation specific to TPU Training plugins * update docstring
Borda
approved these changes
May 26, 2021
carmocca
approved these changes
May 26, 2021
## [1.3.1] - 2021-05-11 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not blocking) extra whitespace
Suggested change
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Next patch release after #7589
Related to #7467
ok #7692 8ba6304 Increment the total batch idx before the accumulation early exit
ok #7683 2c10ecc MAINTAINER has been deprecated
no #7676 ad168fc chlog for 1.3.2 + legacy test
ok #7677 8b01497 Fix global step update when the epoch is skipped
ok #7415 3f460b1 Move parameter validation specific to TPU Training plugins
ok #7674 a54bc5d Fix progress bar print error when called before training
ok #7566 0c958c5 Fix dataloaders are not reset when tuning the model
ok #7563 01109cd Fix/mismatched toggle optimizer
no #7639 03ea68f Removed hparams assignment example in doc
ok #7592 92cf396 Override
broadcast_object_list
fortorch<1.8
ok #7608 ed27190 Clear predict_progress_bar in ProgressBar.getstate
no #7606 6e56f56 docker use $(nproc)
no #7598 922c0a6 Fix incorrect code-snippet in optimizers doc
Questions:
Should Move parameter validation specific to TPU Training plugins #7415 be included since it is a follow up to a bugfix PR?Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃