Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment the total batch idx before the accumulation early exit #7692

Merged
merged 2 commits into from
May 25, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 24, 2021

What does this PR do?

The accumulate check to early exit the batch loop is done before the batch idx increment, so the value is off by one.

Part of #7357

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the bug Something isn't working label May 24, 2021
@carmocca carmocca added this to the v1.3.x milestone May 24, 2021
@carmocca carmocca self-assigned this May 24, 2021
@Borda Borda merged commit 8ba6304 into master May 25, 2021
@Borda Borda deleted the bugfix/total-batch-idx-update branch May 25, 2021 08:23
awaelchli added a commit that referenced this pull request May 25, 2021
* Increment the total batch idx before the accumulation early exit

* Update CHANGELOG
@Borda Borda mentioned this pull request May 25, 2021
Borda pushed a commit that referenced this pull request May 26, 2021
* Increment the total batch idx before the accumulation early exit

* Update CHANGELOG
lexierule pushed a commit that referenced this pull request May 26, 2021
* Increment the total batch idx before the accumulation early exit

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants