Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typing forward references #7770

Merged
merged 2 commits into from
May 31, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 31, 2021

What does this PR do?

These can give circular imports.

Also removed one indentation level in LightningModule.log

Part of #7631

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #7770 (9b8ccdc) into master (a69beab) will decrease coverage by 0%.
The diff coverage is 96%.

@@          Coverage Diff           @@
##           master   #7770   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         199     199           
  Lines       12986   12985    -1     
======================================
- Hits        11994   11980   -14     
- Misses        992    1005   +13     

@justusschock justusschock enabled auto-merge (squash) May 31, 2021 06:56
@Borda Borda added the ready PRs ready to be merged label May 31, 2021
@justusschock justusschock merged commit d47173b into master May 31, 2021
@justusschock justusschock deleted the refactor/typing-fwd-references branch May 31, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants