Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset val_dataloader in tuner/batch_size_scaling #9857

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 7, 2021

What does this PR do?

Fixes #9832

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 changed the title Reset val_dataloader in tuner/batch_size_scaling Reset val_dataloader in tuner/batch_size_scaling Oct 7, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review October 7, 2021 14:53
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #9857 (801e221) into master (4decbc0) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9857   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         178     178           
  Lines       15618   15619    +1     
======================================
+ Hits        14475   14476    +1     
  Misses       1143    1143           

@rohitgr7 rohitgr7 requested a review from four4fish October 8, 2021 07:37
@mergify mergify bot added the ready PRs ready to be merged label Oct 11, 2021
@SkafteNicki SkafteNicki enabled auto-merge (squash) October 11, 2021 07:19
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SkafteNicki SkafteNicki merged commit d71501d into master Oct 11, 2021
@SkafteNicki SkafteNicki deleted the tuner/bs_reset_val branch October 11, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch size found with .tune() is not applied to val_dataloader
5 participants