Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset val_dataloader in tuner/batch_size_scaling for binsearch #9975

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

eladsegal
Copy link
Contributor

@eladsegal eladsegal commented Oct 17, 2021

What does this PR do?

#9857 fixed the issue for power, so this is the fix also for binsearch

Fixes #9832

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #9975 (6bb4bd6) into master (7b4df7b) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9975    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15839   15840     +1     
=======================================
- Hits        14679   14059   -620     
- Misses       1160    1781   +621     

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Totally missed that.

@mergify mergify bot added the ready PRs ready to be merged label Oct 18, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 18, 2021 07:46
@rohitgr7 rohitgr7 added this to the v1.4.x milestone Oct 18, 2021
@rohitgr7 rohitgr7 added bug Something isn't working tuner labels Oct 18, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 merged commit 8c76cf5 into Lightning-AI:master Oct 18, 2021
@eladsegal eladsegal deleted the binsearch-fix branch October 18, 2021 12:20
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged tuner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch size found with .tune() is not applied to val_dataloader
5 participants