Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use FutureWarning for deprecations #744

Closed
Borda opened this issue Jan 11, 2022 · 5 comments · Fixed by #749
Closed

use FutureWarning for deprecations #744

Borda opened this issue Jan 11, 2022 · 5 comments · Fixed by #749
Labels
enhancement New feature or request good first issue Good for newcomers refactoring refactoring and code health
Milestone
v0.7

Comments

@Borda
Copy link
Member

Borda commented Jan 11, 2022

🚀 Feature

see suggestion in #740 (comment)

Motivation

most of the deprecations in TM are meant to users not developers

Alternatives

Additional context

  • exception DeprecationWarning Base class for warnings about deprecated features when those warnings are intended for other Python developers. Ignored by the default warning filters, except in the __main__ module (PEP 565). Enabling the Python Development Mode shows this warning.

  • exception FutureWarning Base class for warnings about deprecated features when those warnings are intended for end users of applications that are written in Python.
@Borda Borda added enhancement New feature or request good first issue Good for newcomers refactoring refactoring and code health labels Jan 11, 2022
@Borda Borda added this to the v0.7 milestone Jan 11, 2022
This was referenced Jan 11, 2022
Merged
Merged
@jscottcronin
Copy link
Contributor

@Borda - I can take this issue.

As I understand, I will convert DeprecationWarning objects to FutureWarning in PR: #740

Correct?

@Borda
Copy link
Member Author

Borda commented Jan 12, 2022 •
edited
Loading

@jscottcronin lets wait till all deprecation from #729 lands, and then I think it ll be updating stream in #745

@Borda
Copy link
Member Author

Borda commented Jan 13, 2022 •
edited
Loading

@jscottcronin now you can proceed... 🐰
can you make it today so we can shoot the final release soon after?

@jscottcronin
Copy link
Contributor

@Borda No problem, working on it now.

@jscottcronin jscottcronin mentioned this issue Jan 13, 2022
Merged
4 tasks
@daniellepintz
Copy link

Should we do the same for Lightning?

@akihironitta akihironitta mentioned this issue Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers refactoring refactoring and code health
Projects
None yet
Milestone
v0.7
Development

Successfully merging a pull request may close this issue.

Changing default stream in deprecation warnings to FutureWarning jscottcronin/metrics
3 participants
@Borda @jscottcronin @daniellepintz