Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify r/fbeta/fbeta_score #740

Merged
merged 7 commits into from
Jan 11, 2022
Merged

Unify r/fbeta/fbeta_score #740

merged 7 commits into from
Jan 11, 2022

Conversation

cuent
Copy link
Contributor

@cuent cuent commented Jan 10, 2022

What does this PR do?

Unify r/fbeta/fbeta_score - part of #729

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #740 (faffa86) into master (7b6736d) will decrease coverage by 0%.
The diff coverage is 86%.

@@          Coverage Diff          @@
##           master   #740   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         169    169           
  Lines        6718   6725    +7     
=====================================
+ Hits         6382   6387    +5     
- Misses        336    338    +2     

@Borda Borda added API / design refactoring refactoring and code health labels Jan 10, 2022
@Borda Borda added this to the v0.7 milestone Jan 10, 2022
@Borda Borda mentioned this pull request Jan 10, 2022
12 tasks
@Borda Borda enabled auto-merge (squash) January 10, 2022 21:59
@mergify mergify bot added the ready label Jan 10, 2022
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😃 Some suggestions

torchmetrics/classification/f_beta.py Outdated Show resolved Hide resolved
torchmetrics/classification/f_beta.py Show resolved Hide resolved
torchmetrics/functional/classification/f_beta.py Outdated Show resolved Hide resolved
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
@Borda Borda merged commit d36fffc into Lightning-AI:master Jan 11, 2022
facebook-github-bot pushed a commit to facebookresearch/recipes that referenced this pull request Mar 14, 2022
Summary:
### New commit log messages
- [d36fffc Unify r/fbeta/fbeta_score (#740)](Lightning-AI/torchmetrics#740)

Reviewed By: tangbinh

Differential Revision: D34814343

fbshipit-source-id: 572d856caf110ab383e2766db93b47a5e2597b69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / design ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants