Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default stream in deprecation warnings to FutureWarning #749

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

jscottcronin
Copy link
Contributor

What does this PR do?

Updates deprecation messages to use FutureWarning instead of DeprecationWarning which is default behavior seen here: https://github.com/Borda/pyDeprecate/blob/75aced79b686e038df73ce8eb2bef49a33bf91a4/deprecate/deprecation.py#L178

Fixes #744

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #749 (6a5e27e) into master (2577417) will decrease coverage by 4%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #749    +/-   ##
======================================
- Coverage      95%    91%    -4%     
======================================
  Files         170    170            
  Lines        6775   6806    +31     
======================================
- Hits         6414   6179   -235     
- Misses        361    627   +266     

@Borda Borda added the enhancement New feature or request label Jan 13, 2022
@Borda Borda enabled auto-merge (squash) January 13, 2022 19:24
@Borda Borda added this to the v0.7 milestone Jan 13, 2022
@Borda Borda merged commit 4dbdc77 into Lightning-AI:master Jan 13, 2022
@mergify mergify bot added the ready label Jan 13, 2022
@jscottcronin jscottcronin deleted the refactor/744 branch January 13, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use FutureWarning for deprecations
3 participants