Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: fixing test docstrings (#1488 #1488

Merged
merged 1 commit into from
Feb 7, 2023
Merged

ruff: fixing test docstrings (#1488 #1488

merged 1 commit into from
Feb 7, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes part of #1484

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Feb 6, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1488 (1678d2c) into master (debd53c) will increase coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1488   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files         213     213           
  Lines       10921   10921           
======================================
+ Hits         9793    9796    +3     
+ Misses       1128    1125    -3     

@mergify mergify bot added the ready label Feb 7, 2023
@Borda Borda changed the title ruff: test docstrings ruff: fixing test docstrings (#1488 Feb 7, 2023
@Borda Borda merged commit b5d8e7b into master Feb 7, 2023
@Borda Borda deleted the ruff/tests_docstrings branch February 7, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants