Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing several issues in docs #1484

Closed
Borda opened this issue Feb 6, 2023 · 0 comments · Fixed by #1595
Closed

Fixing several issues in docs #1484

Borda opened this issue Feb 6, 2023 · 0 comments · Fixed by #1595
Labels
bug / fix Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@Borda
Copy link
Member

Borda commented Feb 6, 2023

📚 Documentation

As we found in #1465 (comment)
Let's remove these todos one by one and fix all skipped issues in a particular PRs:

https://github.com/Lightning-AI/metrics/blob/606dc17759fa7398acc61cf2c4f17fb986db4465/pyproject.toml#L110-L116

If you are interested in giving a hand and helping us, could you create a draft PR as soon as you remove one skip and mention this issue in your PR so we can keep track of ongoing work... 🐰

Also, before you start, please see already finished or ongoing fixes so we avoid duplicating work... 🦦

When yo are done, run: pre-commit --all-files which shall pass all green 🟢

Thanks!

@Borda Borda added the documentation Improvements or additions to documentation label Feb 6, 2023
@Lightning-AI Lightning-AI deleted a comment from github-actions bot Feb 6, 2023
@Borda Borda added bug / fix Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 6, 2023
@ranbir7 ranbir7 mentioned this issue Feb 6, 2023
1 task
@SkafteNicki SkafteNicki added this to the future milestone Feb 7, 2023
This was referenced Mar 5, 2023
@Borda Borda modified the milestones: future, v1.0.0 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants