Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: first line formatting #1498

Merged
merged 3 commits into from
Feb 13, 2023
Merged

ruff: first line formatting #1498

merged 3 commits into from
Feb 13, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes part of #1484
src docstrings now fullfill: D415 [*] First line should end with a period, question mark, or exclamation point

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Feb 10, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1498 (4575e58) into master (3f7e1ac) will decrease coverage by 26%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1498     +/-   ##
========================================
- Coverage      88%     62%    -26%     
========================================
  Files         213     213             
  Lines       10987   10987             
========================================
- Hits         9660    6842   -2818     
- Misses       1327    4145   +2818     

@Borda Borda enabled auto-merge (squash) February 13, 2023 17:42
@Borda Borda requested review from stancld and a team February 13, 2023 18:30
@Borda Borda disabled auto-merge February 13, 2023 18:32
@Borda Borda merged commit 61c2385 into master Feb 13, 2023
@Borda Borda deleted the ruff/first_line_src branch February 13, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants