Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: first line split + imperative mood #1548

Merged
merged 17 commits into from
Feb 24, 2023
Merged

ruff: first line split + imperative mood #1548

merged 17 commits into from
Feb 24, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 24, 2023

What does this PR do?

Fixes part of #1484
Fixes the following in src

  • Missing docstring in public function
  • 1 blank line required between summary line and description
  • First line of docstring should be in imperative mood: ...
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Feb 24, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #1548 (34579e1) into master (82d5271) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1548   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         216     216           
  Lines       11344   11344           
======================================
  Hits         9969    9969           
  Misses       1375    1375           

@Borda Borda changed the title ruff: first line split + imperative mood ruff: first line split + imperative mood (#1548 Feb 24, 2023
@Borda Borda merged commit eb9af2d into master Feb 24, 2023
@Borda Borda deleted the ruff/first_line_split branch February 24, 2023 12:57
@mergify mergify bot added the ready label Feb 24, 2023
Borda pushed a commit that referenced this pull request Feb 24, 2023
@Borda Borda changed the title ruff: first line split + imperative mood (#1548 ruff: first line split + imperative mood Feb 24, 2023
Borda pushed a commit that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants