Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all todos. #1489

Conversation

ranbir7
Copy link

@ranbir7 ranbir7 commented Feb 6, 2023

What does this PR do?

Fixes #1484

I removed the todos Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • [yes ] Did you read the contributor guideline, Pull Request section?
  • [ yes] Did you make sure to update the docs?
  • [no ] Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ranbir7 ranbir7 marked this pull request as ready for review February 6, 2023 20:17
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, any reason why you are removing all; there are a few understands if issues to be fixed...

@mergify mergify bot added the has conflicts label Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1489 (875a2b5) into master (debd53c) will increase coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1489   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files         213     213           
  Lines       10921   10921           
======================================
+ Hits         9793    9794    +1     
+ Misses       1128    1127    -1     

@ranbir7
Copy link
Author

ranbir7 commented Feb 7, 2023

The issue stated that we have to remove each todo one by one
So I did it
Please guide me though
I'm just very new to this

@Borda
Copy link
Member

Borda commented Feb 7, 2023

The issue stated that we have to remove each todo one by one So I did it Please guide me though I'm just very new to this

sure, so pls remove just one line with todo and run pre-commit --all-files and fix all raised issue :)

@Borda Borda marked this pull request as draft February 17, 2023 10:32
@ranbir7 ranbir7 deleted the ranbir7/fixing-several-issues-in-1484 branch February 23, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing several issues in docs
3 participants