Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in MAP related to iou_type="segm" #1763

Merged
merged 9 commits into from
May 10, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1144
Fixes #1743

Apparently the MeanAveragePrecision metric has not been tested with ddp=True since its introduction.
There are multiple flaws in this metric and we should probably revamp it completely but for now lets try to get it a bit more stable.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 8, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1763 (31658fc) into master (cf7604d) will decrease coverage by 0%.
The diff coverage is 46%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1763   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         250     250           
  Lines       14012   14038   +26     
======================================
+ Hits        12255   12266   +11     
- Misses       1757    1772   +15     

tests/unittests/detection/test_map.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label May 9, 2023
@mergify mergify bot removed the ready label May 9, 2023
@mergify mergify bot added the ready label May 10, 2023
@SkafteNicki SkafteNicki merged commit 41bb1fa into master May 10, 2023
@SkafteNicki SkafteNicki deleted the bugfix/map_segm_states branch May 10, 2023 08:04
@SkafteNicki SkafteNicki mentioned this pull request May 15, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDP map evaluation with iou_type segm MeanAveragePrecision throw error in DDP mode
3 participants