Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check in mAP #1784

Merged
merged 13 commits into from
May 22, 2023
Merged

Fix check in mAP #1784

merged 13 commits into from
May 22, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 15, 2023

What does this PR do?

Fixes #1777
Fixes a stupid copy mistake in #1763, that leads to the error nearly always being raised.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1784.org.readthedocs.build/en/1784/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 15, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone May 15, 2023
@Borda Borda enabled auto-merge (squash) May 15, 2023 13:33
@Borda Borda disabled auto-merge May 15, 2023 13:33
@Borda Borda enabled auto-merge (squash) May 15, 2023 13:33
@mergify mergify bot requested a review from a team May 15, 2023 15:04
src/torchmetrics/detection/mean_ap.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #1784 (1adf2ba) into master (fd90062) will decrease coverage by 47%.
The diff coverage is 0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1784     +/-   ##
========================================
- Coverage      87%     40%    -47%     
========================================
  Files         254     254             
  Lines       14251   14249      -2     
========================================
- Hits        12456    5761   -6695     
- Misses       1795    8488   +6693     

@mergify mergify bot added the ready label May 22, 2023
@Borda Borda merged commit 0e46609 into master May 22, 2023
@Borda Borda deleted the bugfix/map_segm_states2 branch May 22, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raise ValueError(f"Rank {rank} and Rank 0 have different values for the list to gather.")
4 participants