Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix postfix in nested collection #1773

Merged
merged 5 commits into from
May 12, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 11, 2023

What does this PR do?

Fixes #1772

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1773.org.readthedocs.build/en/1773/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 11, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone May 11, 2023
@mergify mergify bot requested a review from a team May 11, 2023 07:58
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1773 (661ff03) into master (3ea6062) will increase coverage by 0%.
The diff coverage is 92%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1773   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         253     253           
  Lines       14146   14164   +18     
======================================
+ Hits        12370   12387   +17     
- Misses       1776    1777    +1     

@mergify mergify bot added the ready label May 11, 2023
@Borda Borda enabled auto-merge (squash) May 11, 2023 11:55
@Borda Borda merged commit 17c0e9f into master May 12, 2023
@Borda Borda deleted the bugfix/prefix_postfix_nested_collection branch May 12, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested MetricCollection doesn't add correct prefixes to Metric returning dict
3 participants