Fix dtype casting in spearman and pearson #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
bug / fix
SkafteNicki
requested review from
justusschock,
Borda,
lantiga and
stancld
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2379 +/- ##
======================================
Coverage 69% 69%
======================================
Files 305 305
Lines 17180 17186 +6
======================================
+ Hits 11840 11846 +6
Misses 5340 5340 |
Borda
approved these changes
Feb 14, 2024
4 tasks
Borda
pushed a commit
that referenced
this pull request
Mar 16, 2024
* fix dtype in pearson and spearman * small refactor * update classification * update to new pytest format * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit f4ef8a8)
Borda
pushed a commit
that referenced
this pull request
Mar 18, 2024
* fix dtype in pearson and spearman * small refactor * update classification * update to new pytest format * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit f4ef8a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2314
We have guarded in general against frameworks such as deepspeed changing the metric state dtypes. However, for certain metrics this may still happen if the metric overwrites the state directly instead of doing
self.metric_state += batch_updatewhich nearly all metrics does. This PR simply fixes this for Pearson and Spearman metric.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2379.org.readthedocs.build/en/2379/