Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refix dtype in aggregation metrics #2386

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Refix dtype in aggregation metrics #2386

merged 1 commit into from
Feb 15, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 15, 2024

What does this PR do?

Fixes #2365

Original PR #2366 did actually not fix the problem because I used torch.allclose in the comparison of results instead of hard equal ==. This PR rectify this by making sure we never convert to lower precision internally in the aggregation metrics (using the dtype property from #2379).

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2386.org.readthedocs.build/en/2386/

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Merging #2386 (050a8c7) into master (442c463) will not change coverage.
The diff coverage is 20%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2386   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         307     307           
  Lines       17351   17351           
======================================
  Hits        11960   11960           
  Misses       5391    5391           

@mergify mergify bot added the ready label Feb 15, 2024
@Borda Borda merged commit cdce36b into master Feb 15, 2024
59 checks passed
@Borda Borda deleted the bugfix/dtype_aggregation branch February 15, 2024 11:49
Borda pushed a commit that referenced this pull request Mar 16, 2024
Borda pushed a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
2 participants