Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTFS Ordered Copy Errno 95 #236

Closed
softloft38p-michael opened this issue Jan 12, 2021 · 1 comment · Fixed by #243
Closed

LTFS Ordered Copy Errno 95 #236

softloft38p-michael opened this issue Jan 12, 2021 · 1 comment · Fixed by #243

Comments

@softloft38p-michael
Copy link
Contributor

Trying to run ltfs_ordered_copy on an automounted SAN is returning Check destination (I/O):[Errno 95] Operation not supported. If I add an additional check on line 365:

except IOError as e:
    if e.errno != 61 and e.errno != 93 and e.errno != 95: # Not ENODATA, ENOATTR
...

The copy works as expected. Is it safe to presume that if the operation is not supported the destination is not LTFS or is there another way that this can be handled? In this case, the destination is known not to be LTFS so it works, but it would be good to understand cases where this could be a problem and see if there is a way to allow the copy to proceed even if this cannot be determined programmatically with a flag or something.

Please let me know if there's any data I can provide that would help.

@piste-jp
Copy link
Member

It looks errno==95 is not supported error.

#define	EOPNOTSUPP	95

Your destination filesystem seems not to support extended attribute xattr feature.

So I think your fix is reasonable. But it looks good to forcibly unset -p option when errno==95 because copy2() might fail.

softloft38p-michael added a commit to softloft38p-michael/ltfs that referenced this issue Feb 2, 2021
softloft38p-michael added a commit to softloft38p-michael/ltfs that referenced this issue Feb 2, 2021
softloft38p-michael added a commit to softloft38p-michael/ltfs that referenced this issue Feb 2, 2021
piste-jp pushed a commit that referenced this issue Feb 3, 2021
Treat errno 95 on ltfs_ordered_copy to support destination file system which doesn't support xattr.

Fix #236, #243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants