Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeout values provided by drive #253

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Use timeout values provided by drive #253

merged 2 commits into from
Feb 26, 2021

Conversation

piste-jp
Copy link
Member

Summary of changes

Use timeout values provided by drive as much as possible

Description

Currently, we are using timeout value table defined into LTFS for SCSI timeout. This values come from the spec of drives. But this value is updated sometimes for vendor's reason.

On the other hand, there are drives that support REPORT SUPPORTED OPERATION CODES. Response of the command
includes the timeout value of each commands supported by the drive.

This PR is a change to use this as much as possible.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

Atsushi Abe added 2 commits February 26, 2021 13:57
This change also includes following changes.

  - Remove warning on RHEL8
  - Enhance message checker to support RHEL8
  - Improve auto build checker in macOS and RHEL8 (use message checker)
@piste-jp piste-jp self-assigned this Feb 26, 2021
@piste-jp piste-jp linked an issue Feb 26, 2021 that may be closed by this pull request
@piste-jp piste-jp merged commit 6a3ff61 into LinearTapeFileSystem:v2.4-stable Feb 26, 2021
@piste-jp piste-jp deleted the timeout-pr branch February 26, 2021 10:56
piste-jp pushed a commit that referenced this pull request Feb 26, 2021
This change also includes following changes.
  - Remove warning on RHEL8
  - Enhance message checker to support RHEL8
  - Improve auto build checker in macOS and RHEL8 (use message checker)
  - Fix unknown messages
@piste-jp
Copy link
Member Author

This PR is merged to v2.4-stable and also cherry picked to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch SCSI command timeout values from drive
1 participant