Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change macros for autotools #277

Merged
merged 2 commits into from
May 14, 2021

Conversation

rzerres
Copy link
Contributor

@rzerres rzerres commented May 10, 2021

Summary of changes

This pull request includes following changes or fixes.

  • Substitute depreciated macro AC_TRY_COMPILE
  • Substitute obsolete macro AC_PROG_CC_C99
  • Replace the obsoleted AC_PROG_LIBTOOL with LT_INIT

Description

Using Arch Linux (Universal time: Mo 2021-05-10 11:11:07 UTC), that offers lastest toolchain for autotools, the given master branch renders with errors.
I adapted the relevant macros in configure.ac to meet best practice. This fixes the compile issues.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

* use prefered macro `AC_COMPILE_IFELSE`

Signed-off-by: Ralf Zerres <ralf.zerres@networkx.de>
@piste-jp
Copy link
Member

As you see, the PR would break the build of the first target, RHEL7 x86_64. Because the build check on CentOS7 was failed.

At this time, I can't drop RHEL7/CentOS7 from the list. Please provide a complete fix to work on all distributions on the checker.

https://github.com/LinearTapeFileSystem/ltfs/blob/master/.github/CONTRIBUTING.md

Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I commented, please provide a fix to work on all existing checkers.

configure.ac Outdated Show resolved Hide resolved
Signed-off-by: Ralf Zerres <ralf.zerres@networkx.de>
Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It looks great to me.

@piste-jp piste-jp merged commit f806d70 into LinearTapeFileSystem:master May 14, 2021
@rzerres rzerres deleted the wip-autotools branch May 28, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants