Correct ltfs_check_medium handling of partitions ending in data+fm #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piste-jp
requested changes
Jul 26, 2021
Alter ltfs_check_medium to do a more thorough detection of the state of the partitions after the detected indices and set the eod/append position appropriately if the partition ends in data + filemark Fixes LinearTapeFileSystem#272
I think I've addressed your comments, please check the revised code and let me know what you think. Thanks! |
piste-jp
requested changes
Jul 27, 2021
Change parameter list to include vol and partid instead of device and part number and emit 11020E or 11023E on tape_seek failure as appropriate for the given partid
piste-jp
requested changes
Aug 6, 2021
6 tasks
If a partition ends in in a potential partial index after the known consistent index on that partition, only truncate it if the parameter 'fix' is true in ltfs_check_medium()
|
Thanks, it looks great to me. |
|
Excellent! Thank you for accepting my PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alter ltfs_check_medium to do a more thorough detection of the state of
the partitions after the detected indices and set the eod/append
position appropriately if the partition ends in data + filemark
Fixes #272